Review Request: desktop containment switching. this includes http://mattr.info/r/303/

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/304/#review303
-----------------------------------------------------------


other than the one issue noted below, the patch looks correct.


/trunk/KDE/kdebase/workspace/libs/plasma/view.cpp
<http://mattr.info/r/304/#comment216>

    this is incorrect; when setScreen is called on the View, it should request the containment for that screen. the View is the view, the Corona is the model.
    
    so the way this method was originally is correct.


- Aaron


On 2008-03-17 02:39:39, Chani Armitage wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://mattr.info/r/304/
> -----------------------------------------------------------
> 
> (Updated 2008-03-17 02:39:39)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/libs/plasma/containment.h
>   /trunk/KDE/kdebase/workspace/libs/plasma/containment.cpp
>   /trunk/KDE/kdebase/workspace/libs/plasma/view.h
>   /trunk/KDE/kdebase/workspace/libs/plasma/view.cpp
>   /trunk/KDE/kdebase/workspace/plasma/plasma/desktopview.h
>   /trunk/KDE/kdebase/workspace/plasma/plasma/desktopview.cpp
> 
> Diff: http://mattr.info/r/304/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chani
> 
>