Review Request: desktop containment switching. another try at the setScreen function

[Aaron Seigo]

> On 2008-03-17 11:17:31, Aaron Seigo wrote:
> > /trunk/KDE/kdebase/workspace/libs/plasma/view.cpp, lines 81-82
> > <http://mattr.info/r/304/diff/1/#file1222line81>
> >
> >     this is incorrect; when setScreen is called on the View, it should request the containment for that screen. the View is the view, the Corona is the model.
> >     
> >     so the way this method was originally is correct.
> 
> Chani Armitage wrote:
>     but then it'll set the old screen number on the containment it gets, so it won't *really* set the screen number, so I'll have to set it back... what exactly is supposed to be happening here? what's the point of this function?

View::setScreen sets the screen of the view. Which is to say, it tells the view to map itself to model such that it is viewing the Containment that is currently responsible for $SCREEN. 

Containment::setScreen sets the screen of the Containment. When a view zooms in, since that signal comes from the Containment, the Containment (part of the model) is asking to be reassigned. We use the current screen of the View it happened in association with to define what that reassignment will be.

The "current screen of the View" is defined as the screen of the currently (and about to be previously) associated Containment, . 

Containment may be viewed by more than one view (e.g. a DesktopView and a DashboardView). 


- Aaron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/304/#review303
-----------------------------------------------------------


On 2008-03-17 16:59:00, Chani Armitage wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://mattr.info/r/304/
> -----------------------------------------------------------
> 
> (Updated 2008-03-17 16:59:00)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/plasma/desktopview.cpp
>   /trunk/KDE/kdebase/workspace/libs/plasma/containment.h
>   /trunk/KDE/kdebase/workspace/libs/plasma/containment.cpp
>   /trunk/KDE/kdebase/workspace/libs/plasma/view.cpp
>   /trunk/KDE/kdebase/workspace/plasma/plasma/desktopview.h
> 
> Diff: http://mattr.info/r/304/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chani
> 
>