Review Request: Animates tabswitching

[Mehdi Salem Naraghi]

> On 2008-03-08 05:51:50, Marco Martin wrote:
> > trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/tabbar.cpp, line 269
> > <http://mattr.info/r/278/diff/1/#file1119line269>
> >
> >     braces.

Updated the patch to reflect the coding style guidelines.


- Mehdi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/278/#review272
-----------------------------------------------------------


On 2008-03-09 07:00:03, Mehdi Salem Naraghi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://mattr.info/r/278/
> -----------------------------------------------------------
> 
> (Updated 2008-03-09 07:00:03)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Adds a nice animation to the tabbar when switched. The same animation timer is used that was also used by the icon-shift animation. Unfortunately I made a lot of changes to the paintEvent that could have been done in a less invasive manner keeping much of the original code. I think the original paintEvent coude provided more flexibility. I have too  look into it the next coming days.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/tabbar.h
>   trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/tabbar.cpp
> 
> Diff: http://mattr.info/r/278/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mehdi
> 
>