Review Request: animates tabswitching

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/278/#review273
-----------------------------------------------------------


as for use of QTimeLine here, yes, it should all be using Phase::customAnimation to take advantage of the shared timer as well as to kill the animation based on the loaded plugin (as well as the desktop-wide graphicsEffectsLevel)

i haven't actually tried this patch out yet to see what it looks like in practice, however. i'll do that later today though =)

- Aaron


On 2008-03-08 05:00:37, Mehdi Salem Naraghi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://mattr.info/r/278/
> -----------------------------------------------------------
> 
> (Updated 2008-03-08 05:00:37)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Adds a nice animation to the tabbar when switched. The same animation timer is used that was also used by the icon-shift animation. Unfortunately I made a lot of changes to the paintEvent that could have been done in a less invasive manner keeping much of the original code. I think the original paintEvent coude provided more flexibility. I have too  look into it the next coming days.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/tabbar.h
>   trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/tabbar.cpp
> 
> Diff: http://mattr.info/r/278/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mehdi
> 
>