Review Request: animates tabswitching

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/278/#review272
-----------------------------------------------------------


i wonder if it would be desiderable to put the timeline somewhere globally to kickoff so if in the future there will be other animations in kickoff they will use a single timer (not really sure, aaron, does it make sense?)
apart than that some micro coding style issues:


trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/tabbar.cpp
<http://mattr.info/r/278/#comment204>

    should be
    if (m_lastIndex[0] == -1) {
        m_lastIndex[1] = currentIndex();
    }



trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/tabbar.cpp
<http://mattr.info/r/278/#comment205>

    braces also here



trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/tabbar.cpp
<http://mattr.info/r/278/#comment206>

    braces.


- Marco


On 2008-03-08 05:00:37, Mehdi Salem Naraghi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://mattr.info/r/278/
> -----------------------------------------------------------
> 
> (Updated 2008-03-08 05:00:37)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Adds a nice animation to the tabbar when switched. The same animation timer is used that was also used by the icon-shift animation. Unfortunately I made a lot of changes to the paintEvent that could have been done in a less invasive manner keeping much of the original code. I think the original paintEvent coude provided more flexibility. I have too  look into it the next coming days.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/tabbar.h
>   trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/tabbar.cpp
> 
> Diff: http://mattr.info/r/278/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mehdi
> 
>