[Review Board] transparency for plasma-overlay

[Aaron J. Seigo]

On Sunday 20 July 2008, Chani wrote:
> On July 20, 2008 20:54:42 Chani wrote:
> > http://reviewboard.vidsolbach.de/r/97/
> > no screenshot of the .ui tonight, maybe I'll do one tomorrow

neat, idle vs active opacity. note that opacity is really, really slow since 
it is all done in software. until there is a competent opengl bckend for 
qpainter, there's no way this is going to get better either.

in any case, the patch looks alright, though good practice isn't to use == to 
compare floats due to rounding errors. safer is to do something like:

if (int(m_idleOpacity * 10) == 10) 

this would test to the tenths place with accuracy. but even better is to just 
do:

if (qFuzzyCompare(m_idleOpacity, 1.0))

probably a number of places in plasma we should be doing this =0

this patch also reminds me of the cmplexity of your project, and how a 
document in workspace/plasma/design/ is certainly called for! =)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080721/ac641e46/attachment.pgp