[PATCH] Picture navigation for the frame plasmoid

Aaron J. Seigo aseigo at kde.org
Wed Jul 16 02:38:51 CEST 2008


On Tuesday 15 July 2008, Éric ALBER wrote:
> Tell me what you think about that :)

Frame::hoverEnterEvent should probably call Applet::hoverEnterEvent.

you may want to use Plasm::PaintUtils::shadowText in createTextPixmap instead 
of drawing your own text.

stylistically, getNextImage and getPrevImage should probably be nextImage and 
prevImage.

should size() on this line:

     m_displayPreviousLabel = event->pos().x() < size().width() / 2;

be contentsRect().size()?

otherwise it looks ok from here, though i'll let annma obviously have the last 
say and signoff =)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080715/ed0dece3/attachment.pgp 


More information about the Panel-devel mailing list