[PATCH] bug in animator?

[Aaron J. Seigo]

On Sunday 13 July 2008, Marco Martin wrote:
> On Sunday 13 July 2008, Aaron J. Seigo wrote:
> > On Saturday 12 July 2008, Marco Martin wrote:
> > > adding an item->update() in that area of the animator like this patch
> > > seems to fix the problem.
> > > it's right to do so?
> >
> > it's the right thing, but in the wrong place. where you put it will cause
> > every item being animated to redraw itself regardless. that's obviously
> > not particularly sane =)
> >
> > it should appear at the end of the
> >
> >         if (state->currentInterval <= elapsed) {
> >
> > block.
>
> mmh, at start of that block, maybe? because state can be deleted when
> state->currentFrame >= state->frames

it has to be after the state->currentFrame is updated; so the update call 
should be made on line 619.

it's also a pretty wasteful call as it updates the *whole* item, which is 
horrible for a large item animating small areas of it. this really ought to 
know what the affected rect is .... but again, not sure yet how much effort 
should be put into this right now

> > btw, i haven't touched Animator much at all because i want to see what TT
> > is cooking before i decide whether or not to spend the time on Animator
> > fixing various flaws in it.
>
> agreed, buti want to keep it at least working without the major visual
> glitches :)

heh.. agreed; on that note there is some bad math in there as well that i 
ought to fix.

> btw, do you know when they plan to make it available? qt4.5? 4.6?
> i suppose for kde4.2 we will still have to rely on animator right?

yes

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080713/104e70de/attachment.pgp