[PATCH] bug in animator?

[Marco Martin]

On Sunday 13 July 2008, Aaron J. Seigo wrote:
> On Saturday 12 July 2008, Marco Martin wrote:
> > adding an item->update() in that area of the animator like this patch
> > seems to fix the problem.
> > it's right to do so?
>
> it's the right thing, but in the wrong place. where you put it will cause
> every item being animated to redraw itself regardless. that's obviously not
> particularly sane =)
>
> it should appear at the end of the
>
>         if (state->currentInterval <= elapsed) {
>
> block.

mmh, at start of that block, maybe? because state can be deleted when 
state->currentFrame >= state->frames

> btw, i haven't touched Animator much at all because i want to see what TT
> is cooking before i decide whether or not to spend the time on Animator
> fixing various flaws in it.

agreed, buti want to keep it at least working without the major visual 
glitches :)

btw, do you know when they plan to make it available? qt4.5? 4.6?
i suppose for kde4.2 we will still have to rely on animator right?

Cheers,
Marco Martin

-------------- next part --------------
A non-text attachment was scrubbed...
Name: animator_update2.diff
Type: text/x-diff
Size: 503 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080713/86441927/attachment.bin