[PATCH] applet handle side selection

[Marco Martin]

On Wednesday 09 July 2008, Aaron J. Seigo wrote:
> hi all..
>
> the new applet handle code has a few issues imho:
>
> * the handle is really, really small for larger widgets
>
> * it doesn't always pick which side to appear on very well
yeah, sorry that yesterday i gave up but was toooo tired :)
> attached is a patch that:
>
> * makes the handle the size of the widget if the widget is taller than the
> handle
i think a small size estetically is nicer, but it's true that it's easier to 
lose it off screen, so hmm, ok :)
a small problem i found is that it seems to calculate a too little minimum 
size since assumes that there are 3 icons so the last one can be drawn 
outside theshape, the attached one just puts 4, better abounding :)

>
> * shows the handle on the the side of the applet the mouse enters on,
> unless that would end up putting the handle off screen; if both sides would
> be off scren, we try and pick the one that is least worst (most on screen)

tried to play around with it, still didn't manage to confuse it, it seems 
quite reliable

> what this patch does not do:
>
> * put the close button at the bottom of the handle
agree
> * recalculate where the rect should be in the case we rehover quickly and
> the applet handle gets re-used
>
> * fix the "handle disappears if you hover the applet, move to the handle,
> move back to the applet, move to handle" bug.
tried here to stop the leave timer on hovermove events, seems to work well

> i'll work on those things if this patch works for people.
>
> i'd like to ask that as many of you as possible apply this patch, test it
> out and let me know what you think.

Cheers,
Marco Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: applethandle_somestuff.diff
Type: text/x-diff
Size: 5811 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080709/57282d50/attachment.bin