[PATCH] frame plasmoid: Switch photo when the user clicks on it

[Aaron J. Seigo]

On Friday 04 July 2008, Anne-Marie Mahfouf wrote:
> Le Friday 04 July 2008 14:MM:49 Éric ALBER, vous avez écrit :
> > I also noticed that void mousePressEvent (QGraphicsSceneMouseEvent
> > *event) and other methods are not declared virtual in Plasma/Applet but
> > the same methods are virtual in QGraphicsItem. I also noticed that the
> > destructor of the Applet class is not virtual either. Is this a design
> > choice or has it just been forgotten ?

when a method is declared virtual in a class, it is virtual in all subclasses 
regardless of the use of the virtual keyword in the subclasses. methods don't 
magically become non-virtual down the inheritance hierarchy.

> There are several ways to do it (in my opinion):
> - mouse clicks: like the patch suggests. I am not keen on actions that the
> user cannot be aware of like clicking. If SHIFT-click makes it move
> backward, how is the user aware of that?

yes, i'd recommend against this.

> - triangles like the Comic widget does

the comic applet triangles are not very pretty tbh. i'd recommend something 
more like gwenview's on-hover toolbar.

> - on hover, integrated arrows + a pause button in the handle (the handle
> being the thing where you get the 4 icons on the left)

which would mean extending the handle with API for this. i'm also concerned 
that the handle could rapidly fill up with all sorts of applet specific things, 
but that's something we could think about in 4.2.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080704/5c7a7bbb/attachment.pgp