KDE/kdebase/workspace/plasma/applets/systemtray

[Aaron J. Seigo]

On Monday 30 June 2008, Sebastian Kügler wrote:
> SVN commit 826594 by sebas:
>
> Only set width or height minima, so the systray expands only in
> the expandable direction. minimum width and height are 22 in
> those cases. This patch makes it possible to shrink the systray
>  -- and with it the whole panel -- again, once it has had more
> rows. This wasn't possible after r826397.

ah, makes sense. and it explains why no minimum size was being set at all, i 
bet: the original code was probably trying to prevent this bug, which 
introduced the one i fixed (which re-introduced this one)

good job on fixing it without reintroducing the other problem.

> This makes the whole panel not shrink below 22. If we make that
> possible (by not setting the min height to 22), the systray just
> vanishes when the panel gets smaller. Not sure which situation I
> prefer, ideas?

i think making the panel not shrinkable to less than 22px if the systray is 
just fine; having it disappear altogether is a bit odd and bug-like imho.

Sauer noted in a BR at one point that he'd played with letting icons shrink 
down to 16px. if that's so, then that would be great and we can pin the 
minimum size of a panel to 16px at that point.

i'm ok with 22px though.

systray sucks =)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080630/56a99c15/attachment.pgp