[PATCH] Frame config revamp

[Andre Magalhaes]

2008/1/22 Aaron J. Seigo <aseigo at kde.org>:
> On Tuesday 22 January 2008, Andre Magalhaes wrote:
> > This time I am trying to "fix" the frame applet config.
>
> yay! you're rapidly approaching Plasmoid Of the Week status here ;)
>
> comments:
>
> * maybe get rid of the two radio boxes for round vs square corners and replace
> with a checkbox for rounded corners, with square corners being the implied
> alternative?
Good I will do it, I wasn't liking the checkboxes there also, they
were misplacing

> * the checkboxes and radio buttons should be aligned with the drop down...
> see:
> http://wiki.openusability.org/guidelines/index.php/Design_and_Layout:Layout:Dialogs
Where? I can't see it, the check boxes and radio buttons there are in another
group box, so I don't see how to align them with the drop down.

> * would be nice to eliminate the whitespace in the the single image mode
As explained in another mail, I did this because I prefer the space over a self
resizing widget, but if you think the other way around I can change it.

> * usually we try and keep coding style and functional changes separate, as
> mixing the two makes the functional change patches impossible to read.
Great, next time, not this patch please, I will do it :).

-- 
Andre Moreira Magalhaes (andrunko)
--------------------------------------------------------
Jabber: andrunko at gmail.com
MSN:   andremoreira at msn.com
Skype:  andrunko
Blog:    http://andrunko.blogspot.com