[PATCH] Frame config revamp

Aaron J. Seigo aseigo at kde.org
Wed Jan 23 02:11:18 CET 2008


On Tuesday 22 January 2008, Andre Magalhaes wrote:
> This time I am trying to "fix" the frame applet config.

yay! you're rapidly approaching Plasmoid Of the Week status here ;)

comments:

* maybe get rid of the two radio boxes for round vs square corners and replace 
with a checkbox for rounded corners, with square corners being the implied 
alternative?

* the checkboxes and radio buttons should be aligned with the drop down... 
see: 
http://wiki.openusability.org/guidelines/index.php/Design_and_Layout:Layout:Dialogs

* would be nice to eliminate the whitespace in the the single image mode

* usually we try and keep coding style and functional changes separate, as 
mixing the two makes the functional change patches impossible to read.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080122/b7efa4b6/attachment.pgp 


More information about the Panel-devel mailing list