[PATCH] Frame config revamp

[Aaron J. Seigo]

On Tuesday 22 January 2008, Andre Magalhaes wrote:
> > * the checkboxes and radio buttons should be aligned with the drop
> > down... see:
> > http://wiki.openusability.org/guidelines/index.php/Design_and_Layout:Layo
> >ut:Dialogs
>
> Where? I can't see it, the check boxes and radio buttons there are in
> another group box, so I don't see how to align them with the drop down.

what you want is all the labels on the left side, all the widgets on the 
right. so instead of using the checkbox's built in lable, just put no text in 
it and instead put a QLabel on the left... then right justify all the labels 
and you get:

         Option 1  [  ]
Long Option 2 (__________________)

> > * would be nice to eliminate the whitespace in the the single image mode
>
> As explained in another mail, I did this because I prefer the space over a
> self resizing widget, but if you think the other way around I can change
> it.

i think it's better to expand, personally. this way it just looks like an odd 
bug =)

> > * usually we try and keep coding style and functional changes separate,
> > as mixing the two makes the functional change patches impossible to read.
>
> Great, next time, not this patch please, I will do it :).

great =)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080122/9999a68b/attachment.pgp