[PATCH] update interval bugfix

Aaron J. Seigo aseigo at kde.org
Mon Jan 21 06:30:43 CET 2008


On Wednesday 16 January 2008, Chani wrote:
> this code will fix the problem that if two different intervals on hte same

nice bug to catch and fix =)

this is unecessary however:

-        bool hasUpdates() const;
+        bool hasUpdates();

you can change members in the dptr in a const method just fine.

this could also be done a bit better by making setCachedUpdated() set dirty to 
true. this would achieve the same thing and be even more straight forward, as 
well as removing the need for the extra boolean as well.

after calling setCachedUpdated() in DataEngine::internalUpdateSource, a call 
to d->queueUpdate() is also needed just in case we don't get any other valid 
updates.

API wise ... perhaps setNeedsUpdate(bool needsUpdate = true) would be better 
than setCachedUpdate even?

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080120/f375a459/attachment.pgp 


More information about the Panel-devel mailing list