[Panel-devel] [PATCH] Hover Events in Launcher-Applet + Plasma::Icon

[Aaron J. Seigo]

On Tuesday 01 January 2008, Lukas Appelhans wrote:
> Am Dienstag, 1. Januar 2008 18:48:05 schrieb Aaron J. Seigo:
> > On Tuesday 01 January 2008, Lukas Appelhans wrote:
> > > Hi!
> > > This patch includes 2 things:
> > > 1. an option to not use hover events in Plasma::Icon
> >
> > use case?
>
> Kickoff ;) --> needed for 2.

i don't see the point of this though. why should the icon for kickoff not show 
a hover effect? i really don't see the need for this.

some other style notes:

* use the dptr. there's a Private class for a reason. someone snuck in a 
QSizeF member there which should never have been there. i've fixed that.

* extending the constructor is a no-no. there should be a setter/getter. 
constructor parameters just get out of hand otherwise. also, never use bools 
in such cases, it leads to unreadable code. look at the use of it in the 
kickoff applet code in your patch and see how it's impossible to know without 
looking at the Icon class what it does.

> New patch as attachment.

looks like the same patch ... =)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080101/ef07a08c/attachment.pgp