[Panel-devel] [PATCH] Hover Events in Launcher-Applet + Plasma::Icon

[Lukas Appelhans]

Am Dienstag, 1. Januar 2008 18:48:05 schrieb Aaron J. Seigo:
> On Tuesday 01 January 2008, Lukas Appelhans wrote:
> > Hi!
> > This patch includes 2 things:
> > 1. an option to not use hover events in Plasma::Icon
>
> use case?
Kickoff ;) --> needed for 2.
>
> and this:
>
> +    if (m_reactToHoverEvents)
> +        setAcceptsHoverEvents(true);
>
> goes against the coding style, it should be:
>
> +    if (m_reactToHoverEvents) {
> +        setAcceptsHoverEvents(true);
> +    }
done
>
> > 2. Enable the Plasma::Icon  in Launcher-Applet more natural, only enable
> > it when menu is opened
>
> -    connect(d->icon, SIGNAL(pressed(bool)), this, SLOT(toggleMenu(bool)));
> +    connect(d->icon, SIGNAL(clicked()), this, SLOT(toggleMenu()));
>
> the popup should show on press, not click. this is true of all transient
> style popups (menus, calendars, etc)
ok done


New patch as attachment.

Cheers

Lukas


-------------- next part --------------
A non-text attachment was scrubbed...
Name: plasma.diff
Type: text/x-diff
Size: 4740 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080101/2e7251da/attachment.bin