[Panel-devel] [PATCH] Hover Events in Launcher-Applet + Plasma::Icon

[Lukas Appelhans]

Am Dienstag, 1. Januar 2008 19:53:00 schrieb Aaron J. Seigo:
> On Tuesday 01 January 2008, Lukas Appelhans wrote:
> > Am Dienstag, 1. Januar 2008 18:48:05 schrieb Aaron J. Seigo:
> > > On Tuesday 01 January 2008, Lukas Appelhans wrote:
> > > > Hi!
> > > > This patch includes 2 things:
> > > > 1. an option to not use hover events in Plasma::Icon
> > >
> > > use case?
> >
> > Kickoff ;) --> needed for 2.
>
> i don't see the point of this though. why should the icon for kickoff not
> show a hover effect? i really don't see the need for this.
Ok, no problem, I was a bit worried cause the icon looks then as someone has 
clicked on it :/
>
> some other style notes:
>
> * use the dptr. there's a Private class for a reason. someone snuck in a
> QSizeF member there which should never have been there. i've fixed that.
ok
>
> * extending the constructor is a no-no. there should be a setter/getter.
> constructor parameters just get out of hand otherwise. also, never use
> bools in such cases, it leads to unreadable code. look at the use of it in
> the kickoff applet code in your patch and see how it's impossible to know
> without looking at the Icon class what it does.
ok
>
> > New patch as attachment.
>
> looks like the same patch ... =)

Oops sry, wrong dir :(

Lukas