[Panel-devel] [PATCH] Hover Events in Launcher-Applet + Plasma::Icon

[Aaron J. Seigo]

On Tuesday 01 January 2008, Lukas Appelhans wrote:
> Hi!
> This patch includes 2 things:
> 1. an option to not use hover events in Plasma::Icon

use case?

and this: 

+    if (m_reactToHoverEvents)
+        setAcceptsHoverEvents(true);

goes against the coding style, it should be:

+    if (m_reactToHoverEvents) {
+        setAcceptsHoverEvents(true);
+    }

> 2. Enable the Plasma::Icon  in Launcher-Applet more natural, only enable it
> when menu is opened

-    connect(d->icon, SIGNAL(pressed(bool)), this, SLOT(toggleMenu(bool)));
+    connect(d->icon, SIGNAL(clicked()), this, SLOT(toggleMenu()));

the popup should show on press, not click. this is true of all transient style 
popups (menus, calendars, etc)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080101/be1f9ee0/attachment.pgp