Review Request: Fancy-schmancy Kickoff layout tricks for dissident panel placements

[Will Stephenson]

On Wednesday 27 February 2008 12:27:27 you wrote:
> Will Stephenson wrote:
> > I've added some --reverse previews to the review request.
>
> Looks nice to me (besides some rendering issues, but that can be fixed
> in another patch). If you can separate the logic which fixes the
> --reverse bugs into another patch that can be tested and verified.

Which reverse bug seen in the screenshots do you mean?
* with vertical panels, tabs appear on opposite side of kickoff from the 
panel.  This is normal qlayout RTL switching at work, but intuitively seems 
wrong to me in this case.

* item highlight appears in LTR position, not on top of item
* FlipScrollView is not RTL-aware - descending a menu tree scrolls right and 
the back button is on the left

Only the first one is specific to my patch - not to discount the others, but 
to keep the discussion manageable.

> Then 
> we will be left with the question of "should we reverse the menus when
> we put the menu on the right", and we can discuss a smaller patch.

I'm stepping back from that question until the others have seen the new 
screenshots.

> BTW: what happens when you open new sub-menus? On the old menu, you need
> to open sub-menus twice for them to be displayed in the correct place
> (first they are displayed on top of the parent menu, not on the side).
> Does it happen with your patches as well?

Not sure what you mean by this.  I haven't changed any submenu code so I think 
you may be referring to another bug that is fixed in my svn checkout.  The 
submenus scroll in normally subject to the reverse bug mentioned above.

Will

-- 
Will Stephenson
IRC: Bille