[REVIEW] removing (probably) unnecessary condition in dataUpdated(...)

[Aaron J. Seigo]

On Tuesday 15 April 2008, Chani wrote:
> On April 15, 2008 10:26:04 Aaron J. Seigo wrote:
> > On Tuesday 15 April 2008, Chani wrote:
> > > hmmm. it would be nice to enforce that. but are there any cases where
> > > <1s updates are desired?
> >
> > yes, but we'll align to the second anyways (or as best we can). so a
> > 300ms timer should fire at 300, 600, 1000, 300, 600, 900 .. a 500ms timer
> > should always fire at 500 and 1000 .. i don't think engines need exact
> > sub-second timer resolution (mostly because they don't get it anyways ;)
> > so this should be ok.
>
> in that case we're going to have to remember to fix the alignment
> behaviour.

thinking about it more in the shower this morning, i decided that since we 
can't guarantee exact sub-second timings anyways that we could just go ahead 
and round all requests to multiples of 1000 (100ms, 250ms and 500ms?). we 
already round to the nearest 50ms and no one (besides you, due to spelunking 
in the code itself) seems to have noticed (let alone cared)

> iirc, if you set AlignToMinute with, say, a 15s update, you're 
> going to get updates at 1:00, 1:15, 2:00, 2:15...

ooh, that'd be a bug. =/ will fix.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080416/d3306c3b/attachment.pgp