[REVIEW] removing (probably) unnecessary condition in dataUpdated(...)

[Aaron J. Seigo]

On Saturday 12 April 2008, Rafał Miłecki wrote:
> >  in the meantime, that if() condition cuts the number of repaints in the
> > clock by half in the show seconds case.
>
> Still, it doesn't according to me. Look at this code again, please. It
> detects differences in minute() and not second(). I guess we should
> modify this code to ignore dataUpdate(...) calls only when second() is
> the same as before.

yes, the if () condition is incorrect here indeed, and isn't helping in the 
one case we actually need: multiple second updates.

> We should not care about minutes as this is solved 
> good enought in DataEngine (as I understand you).

yes, that case should be covered.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080412/0fe1ac0f/attachment.pgp