[REVIEW] removing (probably) unnecessary condition in dataUpdated(...)

[Rafał Miłecki]

2008/4/11, Aaron J. Seigo <aseigo at kde.org>:
> On Friday 11 April 2008, Rafał Miłecki wrote:
>  > As far as I understand DataEngine it takes updateIntreval parameter in
>  > connectSource which we use (we put 1sec or 60secs). As the result we
>
> except that we call it with 500ms updates in the 1 second case to get reliable
>  to-the-second resolution.

Uh, I think I can not agree with that. I modified
Clock::dataUpdated(...) in clock.cpp to contain such a code:

m_time = data["Time"].toTime();
kDebug() << "DataEngine called this method with " << m_time.toString();

And what I currently get is:
plasma(29789) Clock::dataUpdated: DataEngine called this method with  "09:01:48"
plasma(29789) Clock::dataUpdated: DataEngine called this method with  "09:01:49"
plasma(29789) Clock::dataUpdated: DataEngine called this method with  "09:01:50"
plasma(29789) Clock::dataUpdated: DataEngine called this method with  "09:01:51"
plasma(29789) Clock::dataUpdated: DataEngine called this method with  "09:01:52"
plasma(29789) Clock::dataUpdated: DataEngine called this method with  "09:01:53"
plasma(29789) Clock::dataUpdated: DataEngine called this method with  "09:01:54"
plasma(29789) Clock::dataUpdated: DataEngine called this method with  "09:01:55"
plasma(29789) Clock::dataUpdated: DataEngine called this method with  "09:01:56"
plasma(29789) Clock::dataUpdated: DataEngine called this method with  "09:01:57"

Are you sure dataUpdated(...) is called every 500ms for 1sec interval?
I can not see it.

-- 
Rafał Miłecki