[Panel-devel] [PATCH] Plasma::ProgressBar

[Jon de Andrés]

El Friday 14 September 2007 00:32:35 Aaron J. Seigo escribió:
> On Thursday 13 September 2007, Jon de Andrés wrote:
> > If it's needed any change in the patch, please tell me.
>
> suggestions:
>
> - put Counter::timer on the stack. will prevent memory leaks (you delete it
> in the dtor, but this is safer still =)

Done

>
> - a little test! great! please commit this in libs/plasma/tests/

Thanks :). I've just applied for a SVN account.
>
> - no spaces inside ()s

I'm in love with astyle :). Done.
>
> otherwise, it looks good code-wise. =)

Thanks again =)

-- 
Jon de Andrés Frías
-------------- next part --------------
A non-text attachment was scrubbed...
Name: plasma_progressbar_and_test_rev1.diff
Type: text/x-diff
Size: 13046 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20070914/3700bf7e/attachment.bin