[Panel-devel] [PATCH] Plasma::ProgressBar

[Aaron J. Seigo]

On Thursday 13 September 2007, Jon de Andrés wrote:
> If it's needed any change in the patch, please tell me.

suggestions:

- put Counter::timer on the stack. will prevent memory leaks (you delete it in 
the dtor, but this is safer still =)

- a little test! great! please commit this in libs/plasma/tests/

- no spaces inside ()s

otherwise, it looks good code-wise. =)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20070913/ffcfcd24/attachment.pgp