[Panel-devel] Applet browser enhancements for SuperKaramba

[Aaron J. Seigo]

On Thursday 11 October 2007, Alexander Wiedenbruch wrote:
> Am Donnerstag, 11. Oktober 2007 schrieb Aaron J. Seigo:
> > On Thursday 11 October 2007, Alexander Wiedenbruch wrote:
> > > Please consider the patches as proof-of-concept. I'd like to hear your
> > > comments.
> >
> > i like the idea in theory ... some comments/questions on the patches
> > themselves:
> >
> > - abstractitem.h (and by extension plasmaitem.h) are meant to be private
> > API and i realy want to avoid installing them at all cost. they are being
> > installed because you're using this in libsuperkaramba, and so need an
> > external reference to it, correct?
>
> correct
>
> > if so, i'd like to find another way to
> > do this. unfortunately nothing is coming to mind at the moment, but there
> > must be a way, such as fetching a list of themes from the SK lib and then
> > populating PlasmaItems inside the model based on that.
>
> The only solution I can think of right now, would be to move
> SuperKarambaItem to plasmaappletitemmodel_p.h, extend AbstractItem with
> PlasmaItem (with pluginName() and arguments()), keep both *Item classes
> private, get the data (name, description, icon) of the themes from skapplet
> by using a combination of QMap/QVariantList and put these into
> SuperKarambaItem.
>
> Unfortunately I need to use the ThemeFile class from libsuperkaramba to
> parse the metadata. I could do that also in the applet browser code but
> that would increase the code for SK in Plasma even more.

i'm ok with that. can we put all the SK specific files in a common subdir at 
least, though? e.g. libs/plasma/superkaramba/ .. that way we will know what 
those files are for.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20071011/cc01a991/attachment.pgp