[Panel-devel] Applet browser enhancements for SuperKaramba

[Aaron J. Seigo]

On Thursday 11 October 2007, Alexander Wiedenbruch wrote:
> Please consider the patches as proof-of-concept. I'd like to hear your
> comments.

i like the idea in theory ... some comments/questions on the patches 
themselves:

- abstractitem.h (and by extension plasmaitem.h) are meant to be private API 
and i realy want to avoid installing them at all cost. they are being 
installed because you're using this in libsuperkaramba, and so need an 
external reference to it, correct? if so, i'd like to find another way to do 
this. unfortunately nothing is coming to mind at the moment, but there must 
be a way, such as fetching a list of themes from the SK lib and then 
populating PlasmaItems inside the model based on that.

- if you could, please add comments where the code is there for SK support in 
libplasma; it'll help us remember and new comers to understand what is going 
on there. the extern "C" in plasmaappletitemmodel.cpp is a good example =)

- minor nitpick: where there is 'return "";' to return an empty 
QString, 'return QString();' will suffice

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20071011/548ee3c5/attachment.pgp