[Panel-devel] [PATCH] Icon mutilation

[Christopher Blauvelt]

On Dec 24, 2007 11:57 AM, Marco Martin <notmart at gmail.com> wrote:

> Merry Christmas Everybody! :P
>
> like the not-so-christmas(tm) subject suggests, this patch throws away
> some
> old stuff that is no more needed or even harmful (like setIconSize) in
> plasma::icon, the stuff removed is
> calculateSize()
> Private::displaySizeHint(const QStyleOptionGraphicsItem *option)
> setIconSize(QSizeF)
>
> since setIconSize was public it could break the applets that used it, i've
> tested/corrected the ones that i tought that used it:
> icon, lock/logout, kickoff, twitter and trash
> did i forgot something?
>
> i will leave this patch hanging here for a quite some time, because since
> it
> is potentially dangerous i would like it to be tested/reviewed for some
> days
> and i would not want to break everything for christmas, it would be a not
> so
> good present :D
>
> Cheers,
> Marco Martin
>
> _______________________________________________
> Panel-devel mailing list
> Panel-devel at kde.org
> https://mail.kde.org/mailman/listinfo/panel-devel
>
>
I like the changes.  I liked them enough that I based my changes on it.
I've attached a patch for consideration based on Marco's patch which allows
you to set the number of lines that are displayed.  These changes are needed
so when an icon on the desktop is clicked on, it displays up to
maxDisplayLines of text.  The default is two.  The patch also fixes some
issues with  Icon::Private::elidedText which would truncate a multi-line
display to one line if the entire text couldn't fit.  It also fixed some
crashes that I encountered.
Chris
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/panel-devel/attachments/20071225/47f9158d/attachment-0001.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: icon_mutilated2.diff
Type: text/x-diff
Size: 15793 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20071225/47f9158d/attachment-0001.bin