On Dec 24, 2007 11:57 AM, Marco Martin <<a href="mailto:notmart@gmail.com">notmart@gmail.com</a>> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Merry Christmas Everybody! :P<br><br>like the not-so-christmas(tm) subject suggests, this patch throws away some<br>old stuff that is no more needed or even harmful (like setIconSize) in<br>plasma::icon, the stuff removed is
<br>calculateSize()<br>Private::displaySizeHint(const QStyleOptionGraphicsItem *option)<br>setIconSize(QSizeF)<br><br>since setIconSize was public it could break the applets that used it, i've<br>tested/corrected the ones that i tought that used it:
<br>icon, lock/logout, kickoff, twitter and trash<br>did i forgot something?<br><br>i will leave this patch hanging here for a quite some time, because since it<br>is potentially dangerous i would like it to be tested/reviewed for some days
<br>and i would not want to break everything for christmas, it would be a not so<br>good present :D<br><br>Cheers,<br><font color="#888888">Marco Martin<br></font><br>_______________________________________________<br>Panel-devel mailing list
<br><a href="mailto:Panel-devel@kde.org">Panel-devel@kde.org</a><br><a href="https://mail.kde.org/mailman/listinfo/panel-devel" target="_blank">https://mail.kde.org/mailman/listinfo/panel-devel</a><br><br></blockquote></div>
<br>I like the changes. I liked them enough that I based my changes on
it. I've attached a patch for consideration based on Marco's patch
which allows you to set the number of lines that are displayed. These
changes are needed so when an icon on the desktop is clicked on, it
displays up to maxDisplayLines of text. The default is two. The patch also fixes some
issues with Icon::Private::elidedText which would truncate a
multi-line display to one line if the entire text couldn't fit. It
also fixed some crashes that I encountered.<br>
Chris