[Panel-devel] [PATCH] Icon mutilation

Marco Martin notmart at gmail.com
Mon Dec 24 18:57:04 CET 2007


Merry Christmas Everybody! :P

like the not-so-christmas(tm) subject suggests, this patch throws away some 
old stuff that is no more needed or even harmful (like setIconSize) in 
plasma::icon, the stuff removed is
calculateSize()
Private::displaySizeHint(const QStyleOptionGraphicsItem *option)
setIconSize(QSizeF)

since setIconSize was public it could break the applets that used it, i've 
tested/corrected the ones that i tought that used it:
icon, lock/logout, kickoff, twitter and trash
did i forgot something?

i will leave this patch hanging here for a quite some time, because since it 
is potentially dangerous i would like it to be tested/reviewed for some days 
and i would not want to break everything for christmas, it would be a not so 
good present :D

Cheers,
Marco Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: icon_mutilated.diff
Type: text/x-diff
Size: 10624 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20071224/746fdacb/attachment-0001.bin 


More information about the Panel-devel mailing list