[Panel-devel] [PATCH] on icon resizing

[Aaron J. Seigo]

On Friday 21 December 2007, Marco Martin wrote:
> ok, so removing calculatesize and setIconSize?
> at the moment with the last patch the approach is intermediate between the
> icon decides the size and the applet decides the size because the aspect
> ratio changes upon resize, and i think it should be done in icon widget
> rather thn in the icon applet because otherwise we will get ton of
> identical duplicate code for every applet that uses an icon

i think what is needed is a way to ask Plasma::Icon "if i want a 48px icon, 
how big do i have to make the whole thing?" and Plasma::Icon can return a 
suitable size that will make for a 48px icon with the current text, etc.

but the applet (or layout) *must* be the ultimate controlling factor.

> > - margins: not sure why this was added particularly, other than to make
> > it work with icon views in Qt or whatever silly thing. but this gives
> > rise to the problems that Craig is seeing. they should just be removed
> > completely.
>
> uhm, no margins at all? wouldn't look ugly? (unless killing the background
> svg)

it wouldn't matter; the background svg should be just fine without an inner 
border.

but yeah, i'm going to kill the background svg because, while i think it has 
great promise as a concept, we're really getting next to no attention from 
artists. they appear here and there now and again and it's just proving 
impossible to make it work with my schedule. they need a lot hand holding and 
have limited access to kde4 desktops. it's a really frustrating (and stupid) 
situation... but without decent art we have to forgoe some of these things. 
*sigh*

> > Marco: feel like doing such code amputations? =)
>
> ok, i will try after the resizing and the icon shadow issues are fixed it's
> confusing enough to have two patches pending for the same file :D

yeah.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20071221/71dfb8ae/attachment.pgp