[Panel-devel] [PATCH] on icon resizing

[Marco Martin]

On Friday 21 December 2007, Aaron J. Seigo wrote:
> On Thursday 20 December 2007, Marco Martin wrote:
> > about the icon widget i have another doubt: is the method calculatesize()
> > still needed at all?
>
> looking at it some more, some things need to die IMHO:
>
> - setIconSize: this implies that the icon can free change its size. i don't
> think that's realistic. if anything, we can limit the number of lines of
> text, but the size of the icon should just be figured out based on what the
> size() of the widget is
ok, so removing calculatesize and setIconSize?
at the moment with the last patch the approach is intermediate between the 
icon decides the size and the applet decides the size because the aspect 
ratio changes upon resize, and i think it should be done in icon widget 
rather thn in the icon applet because otherwise we will get ton of identical 
duplicate code for every applet that uses an icon
>
> - margins: not sure why this was added particularly, other than to make it
> work with icon views in Qt or whatever silly thing. but this gives rise to
> the problems that Craig is seeing. they should just be removed completely.
uhm, no margins at all? wouldn't look ugly? (unless killing the background 
svg)
>
> Marco: feel like doing such code amputations? =)
ok, i will try after the resizing and the icon shadow issues are fixed it's 
confusing enough to have two patches pending for the same file :D

Cheers,
Marco Martin