[Panel-devel] Hello

[William Egert]

i do not have an SVN account.  Is it possible to get one if i have not
really done much before?

-bill

On Dec 11, 2007 10:17 AM, Sebastian Kügler <sebas at kde.org> wrote:

> On Tuesday 11 December 2007 06:16:03 William Egert wrote:
> > would probably help if I actually attach the patch :P
> >
> > -Bill
> >
> > On Dec 11, 2007 12:00 AM, William Egert <begert at gmail.com> wrote:
> > > Here is a third patch.  In this I removed all of the unused variables
> > > (though I have the feeling that they were meant to be used later) and
> > > also tried to initialize some more things in the constructor.
>
> Looks good, please commit. (You have an SVN account?)
>
> In the future, it would be nice to split up this kind of things. Mixing
> code
> changes / cleanups with changes that need a lot of reindentation makes
> reviewing harder and more time-consuming. It also makes it easier to spot
> causes for regressions.
>
> Thanks,
> --
> sebas
>
>  http://www.kde.org | http://vizZzion.org |  GPG Key ID: 9119 0EF9
>
> _______________________________________________
> Panel-devel mailing list
> Panel-devel at kde.org
> https://mail.kde.org/mailman/listinfo/panel-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/panel-devel/attachments/20071211/786368fc/attachment.html