i do not have an SVN account. Is it possible to get one if i have not really done much before?<br><br>-bill<br><br><div class="gmail_quote">On Dec 11, 2007 10:17 AM, Sebastian Kügler <<a href="mailto:sebas@kde.org">sebas@kde.org
</a>> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div class="Ih2E3d">On Tuesday 11 December 2007 06:16:03 William Egert wrote:
<br>> would probably help if I actually attach the patch :P<br>><br>> -Bill<br>><br>> On Dec 11, 2007 12:00 AM, William Egert <<a href="mailto:begert@gmail.com">begert@gmail.com</a>> wrote:<br>> > Here is a third patch. In this I removed all of the unused variables
<br>> > (though I have the feeling that they were meant to be used later) and<br>> > also tried to initialize some more things in the constructor.<br><br></div>Looks good, please commit. (You have an SVN account?)
<br><br>In the future, it would be nice to split up this kind of things. Mixing code<br>changes / cleanups with changes that need a lot of reindentation makes<br>reviewing harder and more time-consuming. It also makes it easier to spot
<br>causes for regressions.<br><br>Thanks,<br><font color="#888888">--<br>sebas<br><br> <a href="http://www.kde.org" target="_blank">http://www.kde.org</a> | <a href="http://vizZzion.org" target="_blank">http://vizZzion.org
</a> | GPG Key ID: 9119 0EF9<br></font><br>_______________________________________________<br>Panel-devel mailing list<br><a href="mailto:Panel-devel@kde.org">Panel-devel@kde.org</a><br><a href="https://mail.kde.org/mailman/listinfo/panel-devel" target="_blank">
https://mail.kde.org/mailman/listinfo/panel-devel</a><br><br></blockquote></div><br>