[Panel-devel] Hello

[Sebastian Kügler]

On Tuesday 11 December 2007 06:16:03 William Egert wrote:
> would probably help if I actually attach the patch :P
>
> -Bill
>
> On Dec 11, 2007 12:00 AM, William Egert <begert at gmail.com> wrote:
> > Here is a third patch.  In this I removed all of the unused variables
> > (though I have the feeling that they were meant to be used later) and
> > also tried to initialize some more things in the constructor.

Looks good, please commit. (You have an SVN account?)

In the future, it would be nice to split up this kind of things. Mixing code 
changes / cleanups with changes that need a lot of reindentation makes 
reviewing harder and more time-consuming. It also makes it easier to spot 
causes for regressions.

Thanks,
-- 
sebas

 http://www.kde.org | http://vizZzion.org |  GPG Key ID: 9119 0EF9 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 481 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20071211/016479c5/attachment.pgp