[Panel-devel] Svg::elementRect and theme configs

[Leo Franchi]

On 7/31/07, Leo Franchi <lfranchi at gmail.com> wrote:
>
>
>
> On 7/31/07, Aaron J. Seigo < aseigo at kde.org> wrote:
> >
> > On Tuesday 31 July 2007, Leo Franchi wrote:
> > > API). So basically in order to get the correct element rect, i had to
> > > add the two lines included in the patch.
> >
> > it *looks* ok (i'm in the middle of recompilling trunk/ on my lappie (at
> > the
> > airport), so can't easily check right now).. have you tested with the
> > analog
> > clock and url applets in plasma to make sure they don't break anything
> > there?
>
>
>
> the only applet which uses elementRect currently is the
>  Script applet, and it does indeed break that :-/
> I'm going to try to figure out exactly why that is so...
>


Ok, i attach a new patch, plasma.svg.patch, that instead of "fixing"
 elementRect, exposes QSvgRenderer::matrixForElement to the client.
This way the default

behaviour remains the same and nothing breaks, but applets
 that need to deal with the transformation matrix can do so.

> Also, regarding the current Theme->setApplicationName(), currently if you
> > > set the application to, say, "amarok", plasma will look for the
> > > [Theme-amarok] group in plasmarc. Now, as Amarok doesn't depend on
> > kdebase,
> > > there might not be a plasmarc at all.
> >
> > that doesn't matter, as it will be created as needed.
> >
> > > So it makes little sense for us to
> > > edit/create plasmarc if none exists. I think it would be a better idea
> > to
> > > look into the application-default config, so amarokrc would hold the
> > > relevant theme data. What do you guys think?
> >
> > as long as it can be done without breaking, for instance, krunner which
> > relies
> > on plasmarc being used. that's why it is as it is. i don't see the
> > probably
> > really? if it's a performance issue that you are concerned about i'd
> > recommend benchmarking it first =)
>
>
> the only concern is that it was a little strange for a
>  user, installing amarok on a kdebase-less system, would
>  have a plasmarc with his amarok-specific theme selection.
>


I attach a test patch to illustrate what I mean. Basically, instead of
looking in plasmarc for [Theme-appname], it looks for
appname.rc, [Theme]. Is this reasonable? Does this break anything? I don't
really know what krunner or anything else
needs...

Also, i attach a patch to fix the buggy patch applied in r695097. It is
mostly ok,  but the change in call from d->source(source) to
d->source(source, false) stops the engine from actually creating the source
when it needs to be created. this fixes things for me.

all 3 patches have been tested against trunk and i can't  notice any adverse
effects.

leo
>
> --
> > Aaron J. Seigo
> > humru othro a kohnu se
> > GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43
> >
> > KDE core developer sponsored by Trolltech
> >
> > _______________________________________________
> > Panel-devel mailing list
> > Panel-devel at kde.org
> > https://mail.kde.org/mailman/listinfo/panel-devel
> >
> >
> >
>
>
> --
> ______________________________________________________
> Leo Franchi                     angel666 at myrealbox.com
> 4305 Charlemagne Ct         lfranchi at gmail.com
> Austin                                 cell: (650) 704 3680
> TX, USA                              home: (650) 329 0125
>



-- 
______________________________________________________
Leo Franchi                    angel666 at myrealbox.com
4305 Charlemagne Ct         lfranchi at gmail.com
Austin                                 cell: (650) 704 3680
TX, USA                              home: (650) 329 0125
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/panel-devel/attachments/20070801/e1f5e7f5/attachment.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: plasma.svg.patch
Type: application/octet-stream
Size: 1959 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20070801/e1f5e7f5/attachment.obj 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: plasma.theme.patch
Type: application/octet-stream
Size: 794 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20070801/e1f5e7f5/attachment-0001.obj 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: plasma.dataengine.patch
Type: application/octet-stream
Size: 563 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20070801/e1f5e7f5/attachment-0002.obj