<span class="gmail_quote">On 7/31/07, <b class="gmail_sendername">Leo Franchi</b> <<a href="mailto:lfranchi@gmail.com" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">lfranchi@gmail.com</a>> wrote:
</span><blockquote class="gmail_quote" style="margin-top: 0; margin-right: 0; margin-bottom: 0; margin-left: 0; margin-left: 0.80ex; border-left-color: #cccccc; border-left-width: 1px; border-left-style: solid; padding-left: 1ex">
<br><br><div><span><span class="gmail_quote">On 7/31/07, <b class="gmail_sendername">Aaron J. Seigo</b> <<a href="mailto:aseigo@kde.org" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)"> aseigo@kde.org
</a>> wrote:</span><blockquote class="gmail_quote" style="margin-top: 0; margin-right: 0; margin-bottom: 0; margin-left: 0; margin-left: 0.80ex; border-left-color: #cccccc; border-left-width: 1px; border-left-style: solid; padding-left: 1ex">
On Tuesday 31 July 2007, Leo Franchi wrote:<br>> API). So basically in order to get the correct element rect, i had to<br>> add the two lines included in the patch.<br><br>it *looks* ok (i'm in the middle of recompilling trunk/ on my lappie (at the
<br>airport), so can't easily check right now).. have you tested with the analog<br>clock and url applets in plasma to make sure they don't break anything there?</blockquote></span><div><br><br>the only applet which uses
elementRect currently is the Script applet, and it does indeed break that :-/ </div>I'm going to try to figure out exactly why that is so...</div></blockquote><div><br><br>Ok, i attach a new patch, plasma.svg.patch
, that instead of "fixing" elementRect, exposes QSvgRenderer::matrixForElement to the client. This way the default <br>behaviour remains the same and nothing breaks, but applets that need to deal with the transformation matrix can do
so. </div><br><blockquote class="gmail_quote" style="margin-top: 0; margin-right: 0; margin-bottom: 0; margin-left: 0; margin-left: 0.80ex; border-left-color: #cccccc; border-left-width: 1px; border-left-style: solid; padding-left: 1ex">
<div><span><blockquote class="gmail_quote" style="margin-top: 0; margin-right: 0; margin-bottom: 0; margin-left: 0; margin-left: 0.80ex; border-left-color: #cccccc; border-left-width: 1px; border-left-style: solid; padding-left: 1ex">
> Also, regarding the current Theme->setApplicationName(), currently if you<br>> set the application to, say, "amarok", plasma will look for the<br>> [Theme-amarok] group in plasmarc. Now, as Amarok doesn't depend on kdebase,
<br>> there might not be a plasmarc at all.<br><br>that doesn't matter, as it will be created as needed.<br><br>> So it makes little sense for us to<br>> edit/create plasmarc if none exists. I think it would be a better idea to
<br>> look into the application-default config, so amarokrc would hold the<br>> relevant theme data. What do you guys think?<br><br>as long as it can be done without breaking, for instance, krunner which relies<br>on plasmarc being used. that's why it is as it is. i don't see the probably
<br>really? if it's a performance issue that you are concerned about i'd<br>recommend benchmarking it first =)</blockquote></span><div><br>the only concern is that it was a little strange for a user, installing amarok on a
kdebase-less system, would have a plasmarc with his amarok-specific theme selection. </div></div></blockquote><div><br><br>I attach a test patch to illustrate what I mean. Basically, instead of looking in plasmarc for [Theme-appname], it looks for
appname.rc, [Theme]. Is this reasonable? Does this break anything? I don't really know what krunner or anything else <br>needs...<br><br>Also, i attach a patch to fix the buggy patch applied in r695097. It is mostly ok, but the change in call from d->source(source) to d->source(source, false) stops the engine from actually creating the source when it needs to be created. this fixes things for me.
<br><br>all 3 patches have been tested against trunk and i can't notice any adverse effects. <br></div><br><blockquote class="gmail_quote" style="margin-top: 0; margin-right: 0; margin-bottom: 0; margin-left: 0; margin-left: 0.80ex; border-left-color: #cccccc; border-left-width: 1px; border-left-style: solid; padding-left: 1ex">
<div><div>leo </div><br><blockquote class="gmail_quote" style="margin-top: 0; margin-right: 0; margin-bottom: 0; margin-left: 0; margin-left: 0.80ex; border-left-color: #cccccc; border-left-width: 1px; border-left-style: solid; padding-left: 1ex">
--<span><br>Aaron J. Seigo<br>humru othro a kohnu se<br>GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43<br><br>KDE core developer sponsored by Trolltech<br><br></span>_______________________________________________
<br>Panel-devel mailing list<br><a href="mailto:Panel-devel@kde.org" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">Panel-devel@kde.org</a><br><a href="https://mail.kde.org/mailman/listinfo/panel-devel" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">
https://mail.kde.org/mailman/listinfo/panel-devel</a><br><br><br></blockquote></div><div><span><br><br clear="all"><br>-- <br>______________________________________________________<br>Leo Franchi <a href="mailto:angel666@myrealbox.com" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">
angel666@myrealbox.com</a><br>4305 Charlemagne Ct <a href="mailto:lfranchi@gmail.com" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)"> lfranchi@gmail.com</a> <br>Austin
cell: (650) 704 3680<br>TX, USA home: (650) 329 0125 </span></div></blockquote><br><br clear="all"><br>-- <br>______________________________________________________ <br>Leo Franchi
<a href="mailto:angel666@myrealbox.com" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">angel666@myrealbox.com</a><br>4305 Charlemagne Ct <a href="mailto:lfranchi@gmail.com" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">
lfranchi@gmail.com</a> <br>Austin cell: (650) 704 3680 <br>TX, USA home: (650) 329 0125