[Panel-devel] Svg::elementRect and theme configs

[Aaron J. Seigo]

On Tuesday 31 July 2007, Leo Franchi wrote:
> API). So basically in order to get the correct element rect, i had to
> add the two lines included in the patch.

it *looks* ok (i'm in the middle of recompilling trunk/ on my lappie (at the 
airport), so can't easily check right now).. have you tested with the analog 
clock and url applets in plasma to make sure they don't break anything there?

> Also, regarding the current Theme->setApplicationName(), currently if you
> set the application to, say, "amarok", plasma will look for the
> [Theme-amarok] group in plasmarc. Now, as Amarok doesn't depend on kdebase,
> there might not be a plasmarc at all. 

that doesn't matter, as it will be created as needed.

> So it makes little sense for us to 
> edit/create plasmarc if none exists. I think it would be a better idea to
> look into the application-default config, so amarokrc would hold the
> relevant theme data. What do you guys think?

as long as it can be done without breaking, for instance, krunner which relies 
on plasmarc being used. that's why it is as it is. i don't see the probably 
really? if it's a performance issue that you are concerned about i'd 
recommend benchmarking it first =)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20070731/7c824030/attachment-0001.pgp