D21271: [WIP] Improve documentation of TextEntity stuff

[Albert Astals Cid]

aacid accepted this revision.
aacid added a comment.
This revision is now accepted and ready to land.


  Thanks for putting up with me.
  
  You don't have a committer account, right?

INLINE COMMENTS

> davidhurka wrote in textpage.h:168
> How do you get from concatenate to append?
> 
> I’m not the best english speaker, but I think concatenate (as verb) does not take that kind of object.
> 
> Well, I will avoid it completely.

concatenate = to put things together as a connected series

https://en.wikipedia.org/wiki/Concatenation says 'For example, the concatenation of "snow" and "ball" is "snowball".'

That's why concatenate to me implies more than one thing, and here's there just one, the string itself.

But i'm not a native english speaker either so may be totally wrong

REPOSITORY
  R223 Okular

BRANCH
  improve-documentation-of-textentity-stuff

REVISION DETAIL
  https://phabricator.kde.org/D21271

To: davidhurka, #okular, aacid
Cc: aacid, yurchor, okular-devel, fbampaloukas, joaonetto, tfella, ngraham, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190623/5cf69759/attachment.html>