D21271: [WIP] Improve documentation of TextEntity stuff

[David Hurka]

davidhurka marked 11 inline comments as done.
davidhurka added a comment.


  In D21271#485445 <https://phabricator.kde.org/D21271#485445>, @aacid wrote:
  
  > You don't have a committer account, right?
  
  
  No.

INLINE COMMENTS

> aacid wrote in textpage.h:168
> concatenate = to put things together as a connected series
> 
> https://en.wikipedia.org/wiki/Concatenation says 'For example, the concatenation of "snow" and "ball" is "snowball".'
> 
> That's why concatenate to me implies more than one thing, and here's there just one, the string itself.
> 
> But i'm not a native english speaker either so may be totally wrong

It was meant differently. It concatenates the TextEntities, which are kind of strings, and more than only one. The result is the one string which is returned. :)

REPOSITORY
  R223 Okular

BRANCH
  improve-documentation-of-textentity-stuff

REVISION DETAIL
  https://phabricator.kde.org/D21271

To: davidhurka, #okular, aacid
Cc: aacid, yurchor, okular-devel, fbampaloukas, joaonetto, tfella, ngraham, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190623/574a938f/attachment.html>