D21271: [WIP] Improve documentation of TextEntity stuff

[David Hurka]

davidhurka added inline comments.

INLINE COMMENTS

> aacid wrote in textpage.h:53
> I'm not convinced we should mention this (and even less in this class), sure it's a bug, but hopefully it'll be fixed and when it does noone will remember to remove this since the bug is not even in this class.

Ok, then I will remove it.

> aacid wrote in textpage.h:168
> concatenate is not the word you want here.
> 
> Concactenate means "apppend" and there's no string passed in to get it appended to.
> 
> "returns it as a string", which as pointed out is already below, but if you really want that sentence to exist please use return as not concatenate it to

How do you get from concatenate to append?

I’m not the best english speaker, but I think concatenate (as verb) does not take that kind of object.

Well, I will avoid it completely.

> aacid wrote in textpage_p.h:32
> You're trying to do to different things here then, this says "improve documentation" so please don't move code around, let's try to focus on the documentation :)

Moving that to a future patch (not defining future right now).

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D21271

To: davidhurka, #okular
Cc: aacid, yurchor, okular-devel, fbampaloukas, joaonetto, tfella, ngraham, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190622/df16761f/attachment-0001.html>