D21755: Replace ToolAction by a more universal “ToggleActionMenu”

[Albert Astals Cid]

aacid added inline comments.

INLINE COMMENTS

> davidhurka wrote in toggleactionmenu.cpp:63
> Debugging...
> `forgetButton()` is connected to `QObject::destroyed` of the toolbar buttons.
> So, `forgetButton()` is called when the toolbar button is destructed.
> But that happens when this ToggleActionMenu //has already been// destructed.
> How is that possible, to call a slot of an already destructed object?
> 
> (BTW: Providing a destructor for ToggleActionMenu does not change anything.)

What you're describing isn't really possible. Connections are disconnected when an object gets destroyed.

How do I reproduce that crash?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D21755

To: davidhurka, #okular
Cc: aacid, #vdg, okular-devel, joaonetto, tfella, ngraham, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190613/700369b0/attachment.html>