D21755: Replace ToolAction by a more universal “ToggleActionMenu”

[David Hurka]

davidhurka marked 5 inline comments as done.
davidhurka added a comment.


  Theoretically works, but signal-slot is tricking me.

INLINE COMMENTS

> toggleactionmenu.cpp:63
> +
> +void ToggleActionMenu::forgetButton( QObject *button )
> +{

Debugging...
`forgetButton()` is connected to `QObject::destroyed` of the toolbar buttons.
So, `forgetButton()` is called when the toolbar button is destructed.
But that happens when this ToggleActionMenu //has already been// destructed.
How is that possible, to call a slot of an already destructed object?

(BTW: Providing a destructor for ToggleActionMenu does not change anything.)

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D21755

To: davidhurka, #okular
Cc: aacid, #vdg, okular-devel, joaonetto, tfella, ngraham, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190613/d239cc21/attachment.html>