D21755: Replace ToolAction by a more universal “ToggleActionMenu”

[David Hurka]

davidhurka added inline comments.

INLINE COMMENTS

> aacid wrote in toggleactionmenu.cpp:63
> What you're describing isn't really possible. Connections are disconnected when an object gets destroyed.
> 
> How do I reproduce that crash?

That’s what puzzles me.

It doesn’t always crash (only 5–10% of times closing Okular). If you add qDebug()s to the functions, you see the destructor beeing called before forgetButton() is called. (Assuming `~ToggleActionMenu() override` is added.) Valgrind confirms that (just run `valgrind okular` and close the window), and complains that forgetButton() is called on an already deleted object. (Invalid read of size 4 in QSet::isEmpty().)

I hope that I misinterpret something.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D21755

To: davidhurka, #okular
Cc: aacid, #vdg, okular-devel, joaonetto, tfella, ngraham, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190614/326c6384/attachment-0001.html>