D18238: Implements a new button on findbar that allows users to choose the color that highlights the text

[Nathaniel Graham]

ngraham added a comment.


  I'm not really sold either. No other app has this setting. It seems like one of the major reasons why we have a color scheme and color chooser system is precisely so individual apps don't have to implement features like these themselves.
  
  I'm sure we can come up with a cleverer way to fix 237014 besides simply adding another configuration option. It's not as bad as it used to be since the search highlight now has a box around it. But maybe the bug here is that we're not using a color from the color scheme for highlighting search results. Kate uses the "Selection Background" color to highlight search results and it works okay. Can we not do this in Okular because it could conflict with the actual selection color because you can have text selected and search results highlighted at the same time? What if we used the "Selection Background" color but tinted it differently for each one?
  
  Or maybe we could use a different shade of yellow for the highlight annotation's default yellow color?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18238

To: joaonetto, #okular
Cc: ngraham, aacid, okular-devel, tfella, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190115/5bdc68e2/attachment-0001.html>