D21971: Replace ToolAction by ToggleActionMenu

[Albert Astals Cid]

aacid added a comment.


  Is it me or this thing doesn't compile?
  
    tsdgeos at xps:~/devel/kde/okular/build:arcpatch-D21971$ make -j1
    [  0%] Automatic MOC for target okularcore
    [  0%] Built target okularcore_autogen
    [ 14%] Built target okularcore
    [ 15%] Automatic MOC for target okularpart
    [ 15%] Built target okularpart_autogen
    [ 16%] Building CXX object CMakeFiles/okularpart.dir/okularpart_autogen/mocs_compilation.cpp.o
    In file included from /home/tsdgeos/devel/kde/okular/build/okularpart_autogen/UYX5XTB5RZ/moc_toggleactionmenu.cpp:10,
                     from /home/tsdgeos/devel/kde/okular/build/okularpart_autogen/mocs_compilation.cpp:24:
    /home/tsdgeos/devel/kde/okular/ui/toggleactionmenu.h:63:5: error: new types may not be defined in a return type
       63 |     enum PopupMode {
          |     ^~~~
    /home/tsdgeos/devel/kde/okular/ui/toggleactionmenu.h:63:5: note: (perhaps a semicolon is missing after the definition of ‘ToggleActionMenu::PopupMode’)
    /home/tsdgeos/devel/kde/okular/ui/toggleactionmenu.h:68:48: error: return type specification for constructor invalid
       68 |     explicit ToggleActionMenu( QObject *parent );
          |                                                ^
    make[2]: *** [CMakeFiles/okularpart.dir/build.make:95: CMakeFiles/okularpart.dir/okularpart_autogen/mocs_compilation.cpp.o] Error 1
    make[1]: *** [CMakeFiles/Makefile2:848: CMakeFiles/okularpart.dir/all] Error 2
    make: *** [Makefile:141: all] Error 2

REPOSITORY
  R223 Okular

BRANCH
  create-configurable-toggleactionmenu

REVISION DETAIL
  https://phabricator.kde.org/D21971

To: davidhurka, simgunz
Cc: aacid, ngraham, simgunz, okular-devel, johnzh, andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20191211/47276403/attachment.html>