<table><tr><td style="">aacid added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21971">View Revision</a></tr></table><br /><div><div><p>Is it me or this thing doesn't compile?</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">tsdgeos@xps:~/devel/kde/okular/build:arcpatch-D21971$ make -j1
[  0%] Automatic MOC for target okularcore
[  0%] Built target okularcore_autogen
[ 14%] Built target okularcore
[ 15%] Automatic MOC for target okularpart
[ 15%] Built target okularpart_autogen
[ 16%] Building CXX object CMakeFiles/okularpart.dir/okularpart_autogen/mocs_compilation.cpp.o
In file included from /home/tsdgeos/devel/kde/okular/build/okularpart_autogen/UYX5XTB5RZ/moc_toggleactionmenu.cpp:10,
                 from /home/tsdgeos/devel/kde/okular/build/okularpart_autogen/mocs_compilation.cpp:24:
/home/tsdgeos/devel/kde/okular/ui/toggleactionmenu.h:63:5: error: new types may not be defined in a return type
   63 |     enum PopupMode {
      |     ^~~~
/home/tsdgeos/devel/kde/okular/ui/toggleactionmenu.h:63:5: note: (perhaps a semicolon is missing after the definition of ‘ToggleActionMenu::PopupMode’)
/home/tsdgeos/devel/kde/okular/ui/toggleactionmenu.h:68:48: error: return type specification for constructor invalid
   68 |     explicit ToggleActionMenu( QObject *parent );
      |                                                ^
make[2]: *** [CMakeFiles/okularpart.dir/build.make:95: CMakeFiles/okularpart.dir/okularpart_autogen/mocs_compilation.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:848: CMakeFiles/okularpart.dir/all] Error 2
make: *** [Makefile:141: all] Error 2</pre></div>

</div></div><br /><div><strong>REPOSITORY</strong><div><div>R223 Okular</div></div></div><br /><div><strong>BRANCH</strong><div><div>create-configurable-toggleactionmenu</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21971">https://phabricator.kde.org/D21971</a></div></div><br /><div><strong>To: </strong>davidhurka, simgunz<br /><strong>Cc: </strong>aacid, ngraham, simgunz, okular-devel, johnzh, andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen<br /></div>