D21971: Replace ToolAction by ToggleActionMenu

Simone Gaiarin noreply at phabricator.kde.org
Sat Dec 7 10:53:16 GMT 2019


simgunz accepted this revision.
simgunz added a comment.
This revision is now accepted and ready to land.


  The class has the features needed for both D15580 <https://phabricator.kde.org/D15580> and D21195 <https://phabricator.kde.org/D21195> and I do not see evident bugs. For me, this revision is good enough for now, and in case we can fix it later (it used in few places so it should not be hard to adapt the code if needed).
  
  If no one has anything more to sat I would proceed in merging it soon.

REPOSITORY
  R223 Okular

BRANCH
  create-configurable-toggleactionmenu

REVISION DETAIL
  https://phabricator.kde.org/D21971

To: davidhurka, simgunz
Cc: ngraham, simgunz, okular-devel, johnzh, andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20191207/425970ab/attachment.html>


More information about the Okular-devel mailing list