D23421: Add "find in this document" to selection context menu

[Nathaniel Graham]

ngraham added a comment.


  Works great. I have some UI suggestions below:

INLINE COMMENTS

> pageview.cpp:4371
>              const QString squeezedText = KStringHandler::rsqueeze( searchText, 21 );
> -            webShortcutsMenu->setTitle( i18n( "Search for '%1' with", squeezedText ) );
> +            webShortcutsMenu->setTitle( i18n( "Search for '%1' in", squeezedText ) );
>  

This grammar change makes it wrong for all the other entries.

Maybe the new "Search for <text> in open document" menu item should be in the base level of the context menu, and not inside the sub-menu.

> pageview.cpp:4374
> +            QAction *action = new QAction(i18n("Opened Document"), webShortcutsMenu);
> +            action->setIcon( QIcon::fromTheme( QStringLiteral("document-open") ) );
> +            connect(action, &QAction::triggered, [searchText, this]() { Q_EMIT this->triggerSearch(searchText);});

The icon should be `document-preview` (`document-open` is used for actions that open documents)

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D23421

To: andisa, #okular
Cc: ngraham, okular-devel, andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190827/d5651d4a/attachment.html>